appveyor.yml: Compile and test with latest version for __cplusplus macro on MSVC#1810
Closed
t-b wants to merge 1 commit into
Closed
appveyor.yml: Compile and test with latest version for __cplusplus macro on MSVC#1810t-b wants to merge 1 commit into
t-b wants to merge 1 commit into
Conversation
…cro on MSVC According to [1] the C++ macro __cplusplus has always the value 199711L even if you enable later version of C++ support via /std. Use one job with /Zc:__cplusplus defined so that we know that it compiles. [1]: https://docs.microsoft.com/en-us/cpp/build/reference/zc-cplusplus?view=vs-2019
t-b
force-pushed
the
add-zc-flag-for-msvc
branch
from
64df667 to
5e07fdf
Compare
Contributor
Author
|
@nlohmann Done. |
nlohmann
requested changes
Nov 3, 2019
Owner
nlohmann
left a comment
nlohmann
left a comment
There was a problem hiding this comment.
Can you check why an AppVeyor check failed?
Contributor
Author
|
@nlohmann See #1695 (comment) for a minimal example showing the problem. I'll will not find the time to fix that soonish. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
Bot
added
the
state: stale
This was referenced Feb 27, 2020
Closed
nlohmann
added
platform: visual studio
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to 1 the C++ macro __cplusplus has always the value 199711L
even if you enable later version of C++ support via /std.
Use one job with /Zc:__cplusplus defined so that we know that it
compiles.
Close #1695.