Properly select "Release" build for Travis#2375
Merged
Merged
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
fca58d0 to
7092890
Compare
Contributor
Author
|
The coverage test requires the use of the "Debug" configuration. From the GCC documentation:
|
Owner
|
@karzhenkov Can you please update to the latest develop branch? I changed a lot of issues in the CI and moved some checks from Travis to GitHub Actions. Maybe the changes of this PR may need to be applied in |
# Conflicts: # .travis.yml
Contributor
Author
|
I think there is nothing here that we can apply to |
nlohmann
reviewed
Mar 25, 2021
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ninja doesn't support multiple build configurations. The option
--config Releasehas no effect whencmake --buildis called. Essentially, all testing was performed for "Debug" configuration, which is the default. Maybe it doesn't really matter, but it's misleading. The proper way to select build configuration here is throughCMAKE_BUILD_TYPE.