fix sfinae on basic_json UDT constructor#919
Merged
nlohmann merged 1 commit intoJan 23, 2018
Merged
Conversation
Avoid compiler errors when performing SFINAE checks on basic_json and incomplete types.
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a compiler error today while playing with
basic_jsonand incomplete types, an error similar to the following happened:Indeed,
std::is_base_ofrequires the second type to be complete.I refactored the existing checks to put them in
detail/meta.hpp.The use of
detail::conjunctionis mandatory to short-circuit the template evaluation.Pull request checklist
Read the Contribution Guidelines for detailed information.
developdirectory, runmake amalgamateto create the single-header filesrc/json.hpp. The whole process is described here.Please don't
#ifdefs or other means.