Add option to use exact palette colors#64
Merged
sbreitbart-NOAA merged 4 commits intomainfrom Jun 6, 2025
Merged
Conversation
…ed to the default behavior (interpolation), for scale_color_nmfs; update documentation
Collaborator
Author
|
@k-doering-NOAA Would you mind taking a look at this first draft? I've only provided the feature update for |
This comment has been minimized.
This comment has been minimized.
Contributor
k-doering-NOAA
left a comment
k-doering-NOAA
left a comment
There was a problem hiding this comment.
I think this makes sense! I had one question about how it works.
And as a reminder - it would be a good to add a test (or more) to cover the new scenarios and make sure they work as we expect!
…ate = FALSE; update documentation
This comment has been minimized.
This comment has been minimized.
Contributor
Code Metrics Report
Code coverage of files in pull request scope (75.0%)
Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add option to use specific colors from nmfspalette palettes, as opposed to the default behavior (interpolation), for scale_color_nmfs; update documentation
Inspiration/credit for the feature: #36