Merged
Conversation
…graphics::image() and is easier to use with a function that will display all palettes at once
This comment has been minimized.
This comment has been minimized.
Contributor
k-doering-NOAA
left a comment
k-doering-NOAA
left a comment
There was a problem hiding this comment.
@sbreitbart-NOAA, thanks for working on this - these changes will improve the package!
I added a few comments, questions, and suggestions to my review for your consideration. I think it would be good to consider them before merging in, although some of them may just be due to my ignorance of pals or looking at only parts of the codebase.
…_palette(); update title of latter function; update documentation
k-doering-NOAA
approved these changes
Jul 1, 2025
Contributor
Code Metrics Report
Code coverage of files in pull request scope (71.0%)
Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
display_nmfs_palette()so that it's based in ggplot2 instead ofgraphics::image()and is easier to use withall_nmfs_palettes()all_nmfs_palettes()