Add theming function

[sbreitbart-NOAA]

Add NMFS-branded theming function, as per #71

[sbreitbart-NOAA]

Hi @k-doering-NOAA ! Are you interested in / do you think you'll have capacity to review this PR within the next month or so? If not, I can ask someone else- I realize you're still acclimating back to work. Thanks!

[k-doering-NOAA]

@sbreitbart-NOAA, that works for me! I will finish by 12/5

[sbreitbart-NOAA]

@sbreitbart-NOAA, that works for me! I will finish by 12/5

Super! Thanks so much, Kathryn!

[k-doering-NOAA]

Hi Sophie,

Overall, it looks good! I was able to run the example plot that uses the theme! I just had a few minor comments for your consideration. They are all optional, if you decide to make no changes I think it is still ok to merge this.

One additional thing I wondered is if the theme should include the fonts recomended by the Fisheries style guide - However, I looked around a bit and it seemed like it could be a rabbit hole (e.g., this post) as it is difficult to know which fonts folks have on their computer. So maybe this isn't worth investigating further.

Thanks for putting this together, it seems like it will be a useful feature!

[sbreitbart-NOAA]

Hi Sophie,

Overall, it looks good! I was able to run the example plot that uses the theme! I just had a few minor comments for your consideration. They are all optional, if you decide to make no changes I think it is still ok to merge this.

One additional thing I wondered is if the theme should include the fonts recomended by the Fisheries style guide - However, I looked around a bit and it seemed like it could be a rabbit hole (e.g., this post) as it is difficult to know which fonts folks have on their computer. So maybe this isn't worth investigating further.

Thanks for putting this together, it seems like it will be a useful feature!

Thanks so much for reviewing this thoroughly and swiftly! You made some great points and I'll momentarily push some changes in response.
Re: the fonts: I think this is a great idea in theory. However, as you note, it could be a headache to implement in a way that nearly guarantees success for the user. I'm very cautious when it comes to fonts as I've had a lot of trouble with them in the past. If/when there comes a dependable solution, let's do it!

[github-actions]

Code Metrics Report

Coverage	Code to Test Ratio	Test Execution Time
87.6%	1:0.3	5s

Code coverage of files in pull request scope (86.3%)

Files	Coverage
R/ggplot2-scales.R	93.8%
R/nmfs_cols.R	71.4%

---

Reported by octocov