Skip to content

fix: add getObjectUrl alias to generateObjectUrl #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fengmk2 merged 1 commit into from
Oct 7, 2023
Merged

fix: add getObjectUrl alias to generateObjectUrl #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/OSSObject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,6 +760,13 @@ export class OSSObject extends OSSBaseClient implements IObjectSimple {
return urlObject.toString();
}

/**
* @alias generateObjectUrl
*/
getObjectUrl(name: string, baseUrl?: string) {
return this.generateObjectUrl(name, baseUrl);
}

/**
* @param policy specifies the validity of the fields in the request.
*
Expand Down
4 changes: 3 additions & 1 deletion test/OSSObject.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2221,7 +2221,7 @@ describe('test/OSSObject.test.ts', () => {
});
});

describe('generateObjectUrl()', () => {
describe('generateObjectUrl() & getObjectUrl()', () => {
it('should return object url', () => {
let name = 'test.js';
let url = ossObject.generateObjectUrl(name);
Expand All @@ -2230,8 +2230,10 @@ describe('test/OSSObject.test.ts', () => {
name = '/foo/bar/a%2Faa/test&+-123~!.js';
url = ossObject.generateObjectUrl(name, 'https://foo.com');
assert.equal(url, 'https://foo.com/foo/bar/a%252Faa/test%26%2B-123~!.js');
assert.equal(ossObject.generateObjectUrl(name, 'https://foo.com'), url);
const url2 = ossObject.generateObjectUrl(name, 'https://foo.com/');
assert.equal(url2, 'https://foo.com/foo/bar/a%252Faa/test%26%2B-123~!.js');
assert.equal(ossObject.generateObjectUrl(name, 'https://foo.com/'), url2);
});
});

Expand Down