Skip to content

Correct behavior for XML canonicalization with namespaces and nested elements #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LoneRifle merged 4 commits into from
Jul 8, 2022
Merged

Correct behavior for XML canonicalization with namespaces and nested elements #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6c9578a
Add failing test
mthadley Mar 17, 2022
27ca996
Fix spec by initializing `prefixesInScope` from `ancestorNamespaces`
mthadley Apr 14, 2022
55f3c6d
Remove accidental `console.log`
mthadley Apr 14, 2022
9e3fc69
Add `;` for consistency
mthadley Apr 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/c14n-canonicalization.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,12 @@ C14nCanonicalization.prototype.process = function(node, options) {
var defaultNsForPrefix = options.defaultNsForPrefix || {};
var ancestorNamespaces = options.ancestorNamespaces || [];

var res = this.processInner(node, [], defaultNs, defaultNsForPrefix, ancestorNamespaces);
var prefixesInScope = [];
for (var i = 0; i < ancestorNamespaces.length; i++) {
prefixesInScope.push(ancestorNamespaces[i].prefix);
}

var res = this.processInner(node, prefixesInScope, defaultNs, defaultNsForPrefix, ancestorNamespaces);
return res;
};

Expand Down
8 changes: 8 additions & 0 deletions test/c14n-non-exclusive-unit-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,3 +176,11 @@ exports["C14n: Don't redeclare an attribute's namespace prefix if already in sco

test_C14nCanonicalization(test, xml, xpath, expected);
}

exports["C14n: Don't declare an attribute's namespace prefix if in scope from parent"] = function(test) {
var xml = "<root xmlns:aaa='bbb'><child1><child2><child3 aaa:foo='bar'></child3></child2></child1></root>"
var xpath = "/root/child1";
var expected = '<child1 xmlns:aaa="bbb"><child2><child3 aaa:foo="bar"></child3></child2></child1>';

test_C14nCanonicalization(test, xml, xpath, expected);
}