Adjust references for node-saml organization#298
Merged
cjbarth merged 1 commit intonode-saml:masterfrom Jun 6, 2023
Merged
Conversation
Contributor
Author
|
@LoneRifle @markstos , I'd like to hear your thoughts on scopped vs. unscopped for this package. |
Contributor
|
As long it as we are compatible with the unscoped NPM package and it's not causing other problems, I would keep using it. In otherwords: Let's stay backwards compatible with what most people are using unless there's a compelling reason not to be. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README badge was pointing to the wrong location and the NPM package name was scoped, which it doesn't seem like we're using yet. We should discuss if we want to move this NPM package to be a scopped one and deprecate the unscopped version. For now, we have to unscope it so that we can do a release.