Rename signingCert -> publicCert and signingKey -> privateKey#315
Rename signingCert -> publicCert and signingKey -> privateKey#315cjbarth merged 1 commit intonode-saml:masterfrom
signingCert -> publicCert and signingKey -> privateKey#315Conversation
Codecov Report
@@ Coverage Diff @@
## master #315 +/- ##
=======================================
Coverage 82.74% 82.74%
=======================================
Files 5 5
Lines 875 875
=======================================
Hits 724 724
Misses 151 151
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
LoneRifle
left a comment
There was a problem hiding this comment.
lgtm otherwise. Interesting to know that this package may have been modelled after its dotnet equivalent.
.../validators/XmlCryptoUtilities/XmlCryptoUtilities/program-repro-misc-validation-and-canon.cs
Outdated
Show resolved
Hide resolved
test/validators/XmlCryptoUtilities/XmlCryptoUtilities/utilities.cs
Outdated
Show resolved
Hide resolved
|
It certainly was built on the .Net mode, but, I think we'd all agree, no one praises the .Net model for its simplicity. What is more, it seems like the interface really hides a lot of complexity under the hood; complexity that we just don't have the resources to develop or maintain. I think I'm happy with the direction we've taken this and I think it gives us room to move forward with the kinds of use-cases that those using this project are encountering. |
No description provided.