Refactor classes into their own files#318
Conversation
Codecov Report
@@ Coverage Diff @@
## master #318 +/- ##
==========================================
- Coverage 81.67% 81.56% -0.12%
==========================================
Files 5 7 +2
Lines 824 819 -5
==========================================
- Hits 673 668 -5
Misses 151 151
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
LoneRifle
left a comment
There was a problem hiding this comment.
lgtm. Some concerns over class naming: rather than strict TitleCase, I would prefer that we respect the casing for acronyms, ie, RSASHA1 instead of RsaSha1. This not only recognises that we are dealing with an acronym here (ie, Secure Hash Algorithm rather than Sha), but also provides an easier upgrade path.
@djaqua may also want to comment with respect to naming conventions
|
It makes it harder to read when multiple acronyms are in a row if we maintain all caps. As for migration, they shouldn't be using these classes anyway, they should be using strings like The following guidelines all say to do it this way:
This is a contrary example, but no one likes it (see https://stackoverflow.com/a/45860122/271351) Which is easier to read |
LoneRifle
left a comment
There was a problem hiding this comment.
Point taken, no further objections!
This moves some code around so that classes, or closely related classes, are in their own files.