Improve and simplify validation logic#373
Merged
cjbarth merged 2 commits intonode-saml:masterfrom Aug 10, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #373 +/- ##
==========================================
+ Coverage 72.56% 72.81% +0.24%
==========================================
Files 9 9
Lines 882 879 -3
Branches 234 233 -1
==========================================
Hits 640 640
+ Misses 151 149 -2
+ Partials 91 90 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
LoneRifle
approved these changes
Aug 9, 2023
Collaborator
LoneRifle
left a comment
LoneRifle
left a comment
There was a problem hiding this comment.
Lgtm. Nice work untangling the flow between checkSignature and validateSignatureValue, so that we can remove the latter!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The validation logic was a little convoluted. This PR aims to clean up that logic a little to make it easier to reason on. The deprecated functions can be removed in the next major release.