Enforce consistent transform processing#380
Merged
cjbarth merged 1 commit intonode-saml:masterfrom Aug 24, 2023
Merged
Conversation
srd90
reviewed
Aug 22, 2023
| const transform = this.findCanonicalizationAlgorithm(transformName); | ||
| transformedXml = transform.process(canonXml, options).toString(); | ||
| if (xpath.isNodeLike(transformedXml)) { | ||
| // If, after processing, `transformedNode` is a string, we can't do anymore transforms on it |
There was a problem hiding this comment.
Is it impossible to apply @xmldom/xmldom and xpath again if input for next transform is string (i.e. to select root Node with xpath)? or something like that...I did not browse source codes before writing this question.
Contributor
Author
There was a problem hiding this comment.
I actually tried that. The problem is detailed in the comment in that function.
If we get a string like <root><child></child></root> and parse it using @xmldom/xmldom, we get <root><child/><root>, which, while having the same meaning, is different, and causes problems for our tests and signatures. The code comment says that this is kind of shortening is incorrect, but I'm not entirely sure why.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During a refactor, a bug was introduced that caused inconsistent processing of transforms. This PR fixes this inconsistency and adds a check to make sure that another inconsistency, that of trying to transform a string, isn't introduced. Ideally, the
xpathlibrary would throw if astringis passed instead of aNode, which would solve this problem.This addresses an issue observed by @srd90 in the bottom part of his comment here.