Merged
Conversation
Update README to reflect defaults removal changes from v5.0.0
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #432 +/- ##
=======================================
Coverage 73.17% 73.17%
=======================================
Files 9 9
Lines 902 902
Branches 239 239
=======================================
Hits 660 660
Misses 143 143
Partials 99 99 ☔ View full report in Codecov by Sentry. |
…into chore/update-readme
cjbarth
approved these changes
Jan 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #431
#431 (comment)
KeyInfoelement with the public certificate now that thegetKeyInfoContentproperty is mandatory and just providingpublicCertdoes not add theKeyInfo. I added this because it wasn't entirely clear when I used the library; if you think it's unnecessary consider removing it, or requesting changes and I'll remove it.