Skip to content

feat: Allow token to be sent on download #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BobLuursema wants to merge 7 commits into
base: main
Choose a base branch
from
+93 −37
Open

feat: Allow token to be sent on download #739

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
54a8fb9
feat: Allow token to be sent on download
BobLuursema Sep 17, 2025
4c35677
Refactor authentication code and add tests
BobLuursema Sep 18, 2025
d749006
Make test expectation explicit
BobLuursema Sep 21, 2025
3603766
Fix username/password auth
BobLuursema Sep 22, 2025
e4b8daa
Fix syntax error
BobLuursema Oct 1, 2025
fc92a59
Merge branch 'main' into use-token-for-download
BobLuursema Oct 3, 2025
e181b90
Merge branch 'main' into use-token-for-download
aduh95 Nov 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make test expectation explicit
  • Loading branch information
@BobLuursema
BobLuursema committed Oct 1, 2025
commit d74900622a3f8eae0b169f4aaa48acf7b565a961
4 changes: 2 additions & 2 deletions tests/npmRegistryUtils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ describe(`npm registry utils fetchAsJson`, () => {
expect(fetchMock).lastCalledWith(new URL(`${DEFAULT_NPM_REGISTRY_URL}/package-name`), expect.objectContaining({
headers: {
...DEFAULT_HEADERS,
authorization: `Bearer ${process.env.COREPACK_NPM_TOKEN}`,
authorization: `Bearer foo`,
},
}));
});
Expand Down Expand Up @@ -110,7 +110,7 @@ describe(`npm registry utils fetchAsJson`, () => {
expect(fetchMock).lastCalledWith(new URL(`https://registry.example.org/some/path/package-name`), expect.objectContaining({
headers: {
...DEFAULT_HEADERS,
authorization: `Bearer ${process.env.COREPACK_NPM_TOKEN}`,
authorization: `Bearer foo`,
},
}));
});
Expand Down