fix: replace weak hash functions with SHA-256 - #329
Merged
legendecas merged 1 commit intoJan 24, 2026
Merged
Conversation
Contributor
Author
|
Sorry for the late. Here is the pr @legendecas. Thanks! |
4 tasks
Contributor
|
ruff format pylib/gyp/generator/ninja.py |
Contributor
Author
|
Updated, thanks! |
Contributor
Author
|
Thanks for the review, could we move on the pr in |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces weak cryptographic hash functions (MD5 and SHA1) with SHA-256 across the
node-gypcodebase to improve security. The changes affect hash generation for: