Skip to content

GitHub Action to run tests on most versions of Node.js#957

Closed
cclauss wants to merge 1 commit into
nodejs:mainfrom
cclauss:patch-1
Closed

GitHub Action to run tests on most versions of Node.js#957
cclauss wants to merge 1 commit into
nodejs:mainfrom
cclauss:patch-1

Conversation

@cclauss

@cclauss cclauss commented Sep 29, 2023

Copy link
Copy Markdown
Contributor

Test results: https://github.com/cclauss/nan/actions

@rvagg Your review, please.

Comment thread .github/workflows/ci.yml Outdated
@cclauss cclauss force-pushed the patch-1 branch 2 times, most recently from 45275bc to a4c43c0 Compare January 13, 2025 08:21
@cclauss cclauss requested review from dsanders11 and kkoopa January 13, 2025 08:23
@cclauss

cclauss commented Jan 13, 2025

Copy link
Copy Markdown
Contributor Author

The tests pass so let’s merge without Node.js v23 until

Comment thread .github/workflows/ci.yml
Comment thread .github/workflows/ci.yml
@cclauss

cclauss commented Feb 2, 2025

Copy link
Copy Markdown
Contributor Author

@kkoopa Your review, please. It is surprising to find a https://github.com/nodejs repo with no automated testing.

@kkoopa

kkoopa commented Feb 5, 2025

Copy link
Copy Markdown
Collaborator

Sorry for the delay. I will look closer later, but for now it seems like there are only a couple versions tested here. Can this be extended to incorporate all the old, ugly releases? We actually do have CI testing, but most of it has broken or been discontinued over the years. AppVeyor still works however and it tests some 22 versions across multiple platforms.

@cclauss

cclauss commented Feb 5, 2025

Copy link
Copy Markdown
Contributor Author

I cannot find the AppVeyor test results.

Can we see a nan-related URL like https://ci.appveyor.com/project/cclauss/appveyor-hack ?

@kkoopa

kkoopa commented Feb 5, 2025 via email

Copy link
Copy Markdown
Collaborator

@cclauss

cclauss commented Feb 9, 2025

Copy link
Copy Markdown
Contributor Author

@kkoopa asked:

Can this be extended to incorporate all the old, ugly releases?

actions/setup-node can indeed run ALL those old, ugly releases, and this demonstrates that most of them now pass.

I would very much appreciate a review of this and my other PRs so that we have updated AppVeyor and GitHub Actions testing in place before we merge solutions to key customer issues:

@cclauss cclauss changed the title GitHub Action to run tests on current versions of Node.js GitHub Action to run tests on all versions of Node.js Feb 9, 2025
@cclauss

cclauss commented Feb 9, 2025

Copy link
Copy Markdown
Contributor Author

@tniessen Your review, please.

@cclauss cclauss changed the title GitHub Action to run tests on all versions of Node.js GitHub Action to run tests on most versions of Node.js Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants