build: add pre-commit package for linting#823
Merged
mhdawson merged 2 commits intonodejs:masterfrom Nov 9, 2020
Merged
Conversation
Member
|
This should land after: #819 |
Member
The checks run against the local master ref. So if the local master ref is outdated, the lint will probably fail for those seemingly unrelated lines. In the CI the comparison branch will always be updated, so it will always require the PR to be rebased on the latest main branch commit so that the checks will not complain about unrelated lines. |
Member
Superlokkus
pushed a commit
to Superlokkus/node-addon-api
that referenced
this pull request
Nov 20, 2020
* build: add incremental clang-format checks * build: add pre-commit package for linting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extends #819 with a pre-commit hook to run the
linttask prior to making a git commit.For example, after I installed the package and tried to make a commit via:
I received this error, because the linting failed:
I was able to forcefully make the commit by adding the
-nflag as mentioned in the error.@legendecas we discussed that the linter runs on the CI because of cb0764a#diff-6ac3f79fc25d95cd1e3d51da53a4b21b939437392578a35ae8cd6d5366ca5485R57 but i find it odd that your PR #819 succeeded, but my local
linttask is failing...?