refactor: use inquirer to implement CLI.prompt#310
Merged
targos merged 1 commit intonodejs:masterfrom Nov 23, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #310 +/- ##
==========================================
+ Coverage 74.03% 74.42% +0.38%
==========================================
Files 22 22
Lines 1406 1400 -6
==========================================
+ Hits 1041 1042 +1
+ Misses 365 358 -7
Continue to review full report at Codecov.
|
priyank-p
approved these changes
Nov 20, 2018
joyeecheung
approved these changes
Nov 22, 2018
Member
joyeecheung
left a comment
joyeecheung
left a comment
There was a problem hiding this comment.
Is it possible to use it to refactor cli.promptForInput?
Member
Author
|
@joyeecheung Probably. I'll try it in another PR. |
Member
Author
|
@joyeecheung I see that |
Member
Author
|
I opened #315 |
Contributor
|
It was a preliminary for #299 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.