try libnode.dll first in load_exe_hook#2834
Merged
Merged
Conversation
7 tasks
|
Can anyone review? |
Contributor
Author
|
I'm not quite sure if it still make sense after such a long time. Maybe you can consider cherry-picking dd56ec0 |
lukekarrys
approved these changes
Dec 2, 2024
Member
|
I have rebased this PR to include only dd56ec0 |
Thank you |
Contributor
Author
Thank you, will it merge? |
i hope so |
StefanStojanovic
approved these changes
Dec 10, 2024
Kreijstal
approved these changes
Dec 10, 2024
lukekarrys
pushed a commit
that referenced
this pull request
Dec 13, 2024
cuva
added a commit
to raycast/napi-rs
that referenced
this pull request
Jul 7, 2026
On Windows, load_all() resolved N-API symbols exclusively from the process executable on MSVC targets. That works when the host is node.exe (or an executable that re-exports Node symbols, like Electron), but fails when Node runs embedded through libnode.dll: the process image has no N-API exports and every addon load errors out. Compile the existing find_node_library() fallback chain (process image first, then an already-loaded libnode/node module) for MSVC targets too, mirroring node-gyp's delay-load hook behavior (nodejs/node-gyp#2834). Subprocess hosts are unaffected: the process-image lookup still wins when the executable exports the symbols.
cuva
added a commit
to raycast/napi-rs
that referenced
this pull request
Jul 7, 2026
On Windows, load_all() resolved N-API symbols exclusively from the process executable on MSVC targets. That works when the host is node.exe (or an executable that re-exports Node symbols, like Electron), but fails when Node runs embedded through libnode.dll: the process image has no N-API exports and every addon load errors out. Compile the existing find_node_library() fallback chain (process image first, then an already-loaded libnode/node module) for MSVC targets too, mirroring node-gyp's delay-load hook behavior (nodejs/node-gyp#2834). Subprocess hosts are unaffected: the process-image lookup still wins when the executable exports the symbols.
Brooooooklyn
pushed a commit
to napi-rs/napi-rs
that referenced
this pull request
Jul 7, 2026
…#3384) On Windows, load_all() resolved N-API symbols exclusively from the process executable on MSVC targets. That works when the host is node.exe (or an executable that re-exports Node symbols, like Electron), but fails when Node runs embedded through libnode.dll: the process image has no N-API exports and every addon load errors out. Compile the existing find_node_library() fallback chain (process image first, then an already-loaded libnode/node module) for MSVC targets too, mirroring node-gyp's delay-load hook behavior (nodejs/node-gyp#2834). Subprocess hosts are unaffected: the process-image lookup still wins when the executable exports the symbols.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm testpassesDescription of change
It is a following PR of nodejs/node#47682.
I've tried to rename my executable to
node.exebut the error is still there.That's because the node.js's symbol is in
libnode.dllbut not in my executable. So,GetModuleHandle(NULL)will not work.However, I think we can try to load
libnode.dllfirst. If failed then fallback to try the executable. That will solve the problem and keep the original path work either.Maybe it is looks like a edge case, but as Node.js has a embedding tutorial in the doc, I think it's worth to do this.
Or please tell me if there is a more simple way to solve my problem.
Test is not included because I need to provide a huge nodedll binary.
Thank you, I love node.js.