Skip to content
This repository was archived by the owner on Jun 18, 2021. It is now read-only.

Fix CI failures on ubuntu1804#123

Merged
richardlau merged 1 commit intonodejs:masterfrom
richardlau:endpointfallback
Mar 5, 2019
Merged

Fix CI failures on ubuntu1804#123
richardlau merged 1 commit intonodejs:masterfrom
richardlau:endpointfallback

Conversation

@richardlau
Copy link
Member

@richardlau richardlau commented Feb 21, 2019

Ports fixes from core:
nodejs/node#25962
nodejs/node#26140

Fixes: #120

@richardlau
Copy link
Member Author

richardlau commented Feb 21, 2019 •
edited
Loading

I've added ubuntu1804 to the CI matrix and kicked off a job against Node.js 11 and the master branch here which fails as reported in #120: https://ci.nodejs.org/job/nodereport-continuous-integration/276

CI Node.js 6: https://ci.nodejs.org/job/nodereport-continuous-integration/278/
Edit: Failure due to use of std::to_string. Fixing...

@richardlau
Copy link
Member Author

richardlau commented Feb 21, 2019

CI Node.js 6: https://ci.nodejs.org/job/nodereport-continuous-integration/282/ (✔️)
CI Node.js 8: https://ci.nodejs.org/job/nodereport-continuous-integration/283/ (✔️)
CI Node.js 10: https://ci.nodejs.org/job/nodereport-continuous-integration/284/ (✔️)
CI Node.js 11: https://ci.nodejs.org/job/nodereport-continuous-integration/285/ (✔️)

This was referenced Feb 21, 2019
Closed
Closed
mhdawson
mhdawson approved these changes Feb 22, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

richardlau
richardlau commented Feb 27, 2019
View reviewed changes
@richardlau
Copy link
Member Author

richardlau commented Feb 28, 2019

CI Node.js 6: https://ci.nodejs.org/job/nodereport-continuous-integration/286/ (✔️)
CI Node.js 8: https://ci.nodejs.org/job/nodereport-continuous-integration/290/ (✔️)
CI Node.js 10: https://ci.nodejs.org/job/nodereport-continuous-integration/288/ (✔️)
CI Node.js 11: https://ci.nodejs.org/job/nodereport-continuous-integration/289/ (✔️)

@richardlau
Fix CI failures on ubuntu1804
0bbe2a4 
Ports fixes from core:
nodejs/node#25962
nodejs/node#26140

PR-URL: nodejs#123
Fixes: nodejs#120
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@richardlau richardlau merged commit d28201c into nodejs:master Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mhdawson mhdawson mhdawson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test suite fails on ubuntu1804

2 participants

@richardlau @mhdawson