Skip to content
This repository was archived by the owner on Apr 22, 2023. It is now read-only.

test: mark more tests as flaky#25807

Closed
orangemocha wants to merge 1 commit intonodejs:v0.10from
orangemocha:flakytlstest
Closed

test: mark more tests as flaky#25807
orangemocha wants to merge 1 commit intonodejs:v0.10from
orangemocha:flakytlstest

Conversation

@orangemocha
Copy link
Copy Markdown
Contributor

@orangemocha orangemocha commented Aug 5, 2015

This test failed in a recent Jenkins run for a change that was 100%
not related to it.

@orangemocha
Copy link
Copy Markdown
Contributor Author

orangemocha commented Aug 5, 2015

Failured log: https://jenkins-iojs.nodesource.com/job/node-test-commit-windows/113/nodes=win2012r2/tapTestReport/test.tap-584/

@orangemocha
Copy link
Copy Markdown
Contributor Author

orangemocha commented Aug 11, 2015

Happened again. @joyent/node-collaborators can I get a LGTM?

@jasnell
Copy link
Copy Markdown
Member

jasnell commented Aug 11, 2015

LGTM. Is there a plan to resolve?

orangemocha added a commit that referenced this pull request Aug 13, 2015
@orangemocha
test: mark test-tls-securepair-server as flaky
a7fee30 
This test failed in a recent Jenkins run for a change that was 100%
not related to it.

PR-URL: #25807
Reviewed-By: James M Snell <jasnell@gmail.com>
@orangemocha orangemocha changed the title test: mark test-tls-securepair-server as flaky test: mark test-tls-securepair-client as flaky Aug 13, 2015
@orangemocha
Copy link
Copy Markdown
Contributor Author

orangemocha commented Aug 13, 2015

Is there a plan to resolve?

The plan is to file P-1 issues as soon as this PR lands, and assign it to the next milestone, so we don't lose track of these.

I tried to land the initial change but it failed because of more flaky tests. Added another commit. PTAL.

@orangemocha orangemocha changed the title test: mark test-tls-securepair-client as flaky test: mark more tests as flay Aug 13, 2015
@orangemocha orangemocha changed the title test: mark more tests as flay test: mark more tests as flaky Aug 13, 2015
@joaocgreis
Copy link
Copy Markdown
Member

joaocgreis commented Aug 13, 2015

LGTM

misterdjules
misterdjules reviewed Aug 14, 2015
View reviewed changes
Comment thread test/internet/internet.status Outdated
Copy link
Copy Markdown

@misterdjules misterdjules Aug 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly related to #25858. I ran into this problem also on jenkins.nodejs.org on the Ubuntu 14.04 Jenkins agent, and fixed the DNS server configuration manually.

@orangemocha
Copy link
Copy Markdown
Contributor Author

orangemocha commented Aug 14, 2015

I will land this minus the test-http-dns-fail change, since we believe that #25858 has been fixed.

@orangemocha
Copy link
Copy Markdown
Contributor Author

orangemocha commented Aug 14, 2015

PR updated. It should be ready to land.

@misterdjules
Copy link
Copy Markdown

misterdjules commented Aug 14, 2015

@orangemocha OK, so test-tls-securepair-client.js has been made non flaky in the meantime? I don't see it anymore in this PR.

@orangemocha
Copy link
Copy Markdown
Contributor Author

orangemocha commented Aug 14, 2015

That part already landed in a7fee30

orangemocha added a commit that referenced this pull request Aug 17, 2015
@orangemocha
test: mark more tests as flaky
841a6dd 
PR-URL: #25807
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>
@orangemocha
Copy link
Copy Markdown
Contributor Author

orangemocha commented Aug 17, 2015

Landed, with some additional tweaks, in 841a6dd. Will now open the corresponding issues.

@rvagg rvagg mentioned this pull request Sep 11, 2015
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

flaky-test test v0.10

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@orangemocha @jasnell @joaocgreis @misterdjules