Skip to content

url: improve parsing speed #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bnoordhuis wants to merge 2 commits into from
Closed

url: improve parsing speed #102

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36aeae8
url: improve parsing speed
CGavrila Oct 28, 2014
b7fc957
benchmark: add url benchmarks
bnoordhuis Dec 6, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
url: improve parsing speed 
The url.parse() function now checks whether an escapable character is
in the URL before trying to escape it.

PR-URL: nodejs/node-v0.x-archive#8638
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  • Loading branch information
@CGavrila @bnoordhuis
CGavrila authored and bnoordhuis committed Dec 6, 2014
commit 36aeae8610d478760460cb5f14103a940c20b0d8
10 changes: 6 additions & 4 deletions lib/url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,11 +319,13 @@ Url.prototype.parse = function(url, parseQueryString, slashesDenoteHost) {
// need to be.
for (var i = 0, l = autoEscape.length; i < l; i++) {
var ae = autoEscape[i];
var esc = encodeURIComponent(ae);
if (esc === ae) {
esc = escape(ae);
if (rest.indexOf(ae) !== -1) {
var esc = encodeURIComponent(ae);
if (esc === ae) {
esc = escape(ae);
}
rest = rest.split(ae).join(esc);
}
rest = rest.split(ae).join(esc);
}
}

Expand Down