build: add rule to clean addon tests build#11519
build: add rule to clean addon tests build#11519joyeecheung wants to merge 1 commit intonodejs:masterfrom
Conversation
|
yes please |
bnoordhuis
left a comment
There was a problem hiding this comment.
LGTM. FWIW, there's another add-on in test/gc.
|
@bnoordhuis Oh yes, though I think that one should be @Trott +1 on the idea of adding this to vcbuild.bat, though I know so little about how to write one and I don't have Windows at the moment (technically one doesn't need Windows to consume it, but still), so I think better leave to another PR if anyone want to do it :) |
|
Hmm...I've tried to do a |
|
ARM failure is not a failure, as usual.. Landed in 813b312, thanks! |
Add a `test-addons-clean` to the Makefile to clean up files generated during testing addons. PR-URL: #11519 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Add a `test-addons-clean` to the Makefile to clean up files generated during testing addons. PR-URL: nodejs#11519 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Add a `test-addons-clean` to the Makefile to clean up files generated during testing addons. PR-URL: #11519 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
|
Landed in in v6.x-staging. If it should land in v4.x-staging, please open a backport PR |
|
Depends on #10856 |
Add a `test-addons-clean` to the Makefile to clean up files generated during testing addons. PR-URL: #11519 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Add a rule to the makefile to clean up files generated during testing addons.
Note: when switching from a newer branch, where the addon tests have been built, to an older branch that don't have some of the addon tests, there would be leftover
builddirectories in those test folders.test/addons/.buildstampwould try to use node-gyp to build them, only to find thebinding.gypmissing. If we run this rule before switching branches, there won't be leftoverbuildand those test folders would not be kept when the branches are switched. I think thetest/addons/.buildstampcan have some kind of conditions to avoid that or just delete folders with onlybuild, but not sure what's the appropriate way to do this.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build