build: make build-addons execute parallel#12230
Closed
danbev wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
Currently the building of addons and addons-napi are done sequentially but could be done in parallel which this commit tries to address.
nodejs-github-bot
added
the
build
Contributor
Author
2 tasks
addaleax
approved these changes
Apr 5, 2017
Contributor
|
I am not in favour. Mainly because the compilation logs are interleaved and difficult to understand. That said, I am 0 on this. |
Member
Contributor
Author
|
Closing in favour of #12231 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the building of addons and addons-napi are done sequentially
but could be done in parallel which this commit tries to address.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build