add missing ) in CONTRIBUTING.md#12444
Closed
matkoniecz wants to merge 1 commit intonodejs:masterfrom
matkoniecz:missing_closing_)
Closed
add missing ) in CONTRIBUTING.md#12444matkoniecz wants to merge 1 commit intonodejs:masterfrom matkoniecz:missing_closing_)
matkoniecz wants to merge 1 commit intonodejs:masterfrom
matkoniecz:missing_closing_)
Conversation
addaleax
approved these changes
Apr 16, 2017
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
Can you prefix your commit message with doc:? Otherwise this looks good. 👍
vsemozhetbyt
approved these changes
Apr 16, 2017
watilde
approved these changes
Apr 16, 2017
benjamingr
approved these changes
Apr 16, 2017
gibfahn
approved these changes
Apr 16, 2017
ghost
approved these changes
Apr 17, 2017
cjihrig
approved these changes
Apr 17, 2017
Member
|
I'm going to ship this to master. |
Contributor
Author
Done. |
watilde
pushed a commit
to watilde/node
that referenced
this pull request
Apr 17, 2017
PR-URL: nodejs#12444 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Member
|
Landed in 6724f78. Thanks! |
Member
|
Oops, I didn't wait for 24h for landing, but I hope this change didn't need to wait for a day to land since it just fixed a typo in a doc. Either way, I will check the created date of the PR carefully for next time. Thanks. |
Contributor
|
@watilde It seems it is probably OK: #12221 (comment) |
Contributor
Author
|
@watilde According to https://github.com/nodejs/node/blob/1e12c7396809e67de738b888d813301fb29f9efa/doc/onboarding.md#reviewing-prs There is a minimum waiting time which we try to respect for non-trivial changes" (bolding mine). |
Member
|
This one was more than ok to land inside of the 48 hour period. |
evanlucas
pushed a commit
that referenced
this pull request
Apr 25, 2017
PR-URL: #12444 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Merged
evanlucas
pushed a commit
that referenced
this pull request
May 1, 2017
PR-URL: #12444 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
PR-URL: #12444 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
May 15, 2017
PR-URL: #12444 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 18, 2017
PR-URL: #12444 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
PR-URL: nodejs/node#12444 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc