tests: remove common.PORT from cluster-worker-disconnect-on-error#12457
Closed
sebastianplesciuc wants to merge 1 commit intonodejs:masterfrom
sebastianplesciuc:common-port-cluster-worker-error
Closed
tests: remove common.PORT from cluster-worker-disconnect-on-error#12457sebastianplesciuc wants to merge 1 commit intonodejs:masterfrom sebastianplesciuc:common-port-cluster-worker-error
sebastianplesciuc wants to merge 1 commit intonodejs:masterfrom
sebastianplesciuc:common-port-cluster-worker-error
Conversation
Author
|
Felt like this change warranted another pull request since it's not just an argument change. Please let me know if it can be improved. |
benjamingr
approved these changes
Apr 17, 2017
Member
benjamingr
left a comment
benjamingr
left a comment
There was a problem hiding this comment.
Changes LGTM, although I'd change:
+ if (typeof msg.port != 'undefined') {
To assert that message.port is not undefined rather than ignore the message in that case and add a mustCall assertion.
santigimeno
requested changes
Apr 17, 2017
Member
There was a problem hiding this comment.
I would send the port info in the listen() callback
Member
There was a problem hiding this comment.
I would wrap the callback with common.mustCall()
Remove common.PORT from test-cluster-worker-disconnect-on-error possibility that a dynamic port used in another test will collide with common.PORT. Refs: #12376
Author
|
@benjamingr @santigimeno I made the requested changes. I hope I understood your suggestions. Please let me know how it looks. Thanks! |
santigimeno
approved these changes
Apr 17, 2017
cjihrig
approved these changes
Apr 17, 2017
ghost
approved these changes
Apr 17, 2017
sebastianplesciuc
changed the title
jasnell
approved these changes
Apr 17, 2017
64 tasks
hiroppy
approved these changes
Apr 18, 2017
jasnell
pushed a commit
that referenced
this pull request
Apr 19, 2017
Remove common.PORT from test-cluster-worker-disconnect-on-error possibility that a dynamic port used in another test will collide with common.PORT. PR-URL: #12457 Ref: #12376 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Member
|
Landed in a2843f2 |
evanlucas
pushed a commit
that referenced
this pull request
Apr 25, 2017
Remove common.PORT from test-cluster-worker-disconnect-on-error possibility that a dynamic port used in another test will collide with common.PORT. PR-URL: #12457 Ref: #12376 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Merged
evanlucas
pushed a commit
that referenced
this pull request
May 1, 2017
Remove common.PORT from test-cluster-worker-disconnect-on-error possibility that a dynamic port used in another test will collide with common.PORT. PR-URL: #12457 Ref: #12376 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
Remove common.PORT from test-cluster-worker-disconnect-on-error possibility that a dynamic port used in another test will collide with common.PORT. PR-URL: #12457 Ref: #12376 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
gibfahn
pushed a commit
that referenced
this pull request
May 16, 2017
Remove common.PORT from test-cluster-worker-disconnect-on-error possibility that a dynamic port used in another test will collide with common.PORT. PR-URL: #12457 Ref: #12376 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 18, 2017
Remove common.PORT from test-cluster-worker-disconnect-on-error possibility that a dynamic port used in another test will collide with common.PORT. PR-URL: #12457 Ref: #12376 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
Remove common.PORT from test-cluster-worker-disconnect-on-error possibility that a dynamic port used in another test will collide with common.PORT. PR-URL: nodejs/node#12457 Ref: nodejs/node#12376 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove common.PORT from test-cluster-worker-disconnect-on-error
possibility that a dynamic port used in another test will collide
with common.PORT.
Refs: #12376
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test