Skip to content

build: fix ninja build failure #12484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danbev wants to merge 6 commits into from
Closed

build: fix ninja build failure #12484

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5d91780
build: fix ninja build failure
danbev Apr 18, 2017
e65f70d
make win settings optional
danbev Apr 19, 2017
9a87428
add check for .obj file extensions
danbev Apr 19, 2017
a543ed0
prefix OBJ_SEPARATOR with slash for ninja gen
danbev Apr 20, 2017
1f9b572
make if/else out of the generator statement
danbev Apr 20, 2017
36e54a7
remove debug-agent from cctest target
danbev May 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove debug-agent from cctest target 
This file has been removed in upstream/master but was still included in
the cctest target causing an error.
  • Loading branch information
@danbev
danbev committed May 11, 2017
commit 36e54a70abea1618e5fe39c332fa4312f913ab80
1 change: 0 additions & 1 deletion node.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,7 +623,6 @@
'<(OBJ_PATH)<(OBJ_SEPARATOR)node_buffer.<(OBJ_SUFFIX)',
'<(OBJ_PATH)<(OBJ_SEPARATOR)node_i18n.<(OBJ_SUFFIX)',
'<(OBJ_PATH)<(OBJ_SEPARATOR)node_url.<(OBJ_SUFFIX)',
'<(OBJ_PATH)<(OBJ_SEPARATOR)debug-agent.<(OBJ_SUFFIX)',
'<(OBJ_PATH)<(OBJ_SEPARATOR)util.<(OBJ_SUFFIX)',
'<(OBJ_PATH)<(OBJ_SEPARATOR)string_bytes.<(OBJ_SUFFIX)',
'<(OBJ_PATH)<(OBJ_SEPARATOR)string_search.<(OBJ_SUFFIX)',
Expand Down