Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
dgram: fixed buffer sizes in tests
Buffer sizes were not accepted by OS if they were
below a minimum threshold, therefore tests would
fail.
  • Loading branch information
DamienOReilly committed Sep 10, 2017
commit f4d35646aed2d32b4e9f36640be35c5181a9e93f
12 changes: 6 additions & 6 deletions test/parallel/test-dgram-createSocket-type.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,17 +44,17 @@ validTypes.forEach((validType) => {
{
const socket = dgram.createSocket({
type: 'udp4',
recvBufferSize: 1300,
sendBufferSize: 1800
recvBufferSize: 10000,
sendBufferSize: 15000
});

socket.bind(common.mustCall(() => {
// note: linux will double the buffer size
assert.ok(socket.getRecvBufferSize() === 1300 ||
socket.getRecvBufferSize() === 2600,
assert.ok(socket.getRecvBufferSize() === 10000 ||
socket.getRecvBufferSize() === 20000,
'SO_RCVBUF not 1300 or 2600');
assert.ok(socket.getSendBufferSize() === 1800 ||
socket.getSendBufferSize() === 3600,
assert.ok(socket.getSendBufferSize() === 15000 ||
socket.getSendBufferSize() === 30000,
'SO_SNDBUF not 1800 or 3600');
socket.close();
}));
Expand Down
6 changes: 3 additions & 3 deletions test/parallel/test-dgram-socket-buffer-size.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,11 @@ const dgram = require('dgram');
const socket = dgram.createSocket('udp4');

socket.bind(common.mustCall(() => {
socket.setRecvBufferSize(1200);
socket.setSendBufferSize(1200);
socket.setRecvBufferSize(10000);
socket.setSendBufferSize(10000);

// note: linux will double the buffer size
const expectedBufferSize = common.isLinux ? 2400 : 1200;
const expectedBufferSize = common.isLinux ? 20000 : 10000;
assert.strictEqual(socket.getRecvBufferSize(), expectedBufferSize);
assert.strictEqual(socket.getSendBufferSize(), expectedBufferSize);
socket.close();
Expand Down