n-api: add fast paths for integer getters#14393
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
n-api: add fast paths for integer getters#14393addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
addaleax
added
dont-land-on-v4.x
node-api
nodejs-github-bot
added
c++
bnoordhuis
approved these changes
Jul 20, 2017
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
LGTM. Are there already tests for these code paths?
mscdex
added
the
performance
jasnell
approved these changes
Jul 20, 2017
cjihrig
approved these changes
Jul 20, 2017
XadillaX
reviewed
Jul 21, 2017
Contributor
XadillaX
left a comment
XadillaX
left a comment
There was a problem hiding this comment.
Any test case or performance test?
Member
Author
|
Both the fast paths and the slow paths are already tested by addons-napi/test_conversions. Regarding performance, I didn’t explicitly measure, but judging from #14379 this just makes a lot of sense. |
Member
Author
TimothyGu
approved these changes
Jul 21, 2017
jasongin
approved these changes
Jul 21, 2017
Member
Author
|
Landed in 57a4ceb |
Closed
Merged
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 10, 2018
Ref: nodejs#14379 PR-URL: nodejs#14393 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #14379
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
n-api
/cc @nodejs/n-api