Skip to content

benchmark: fix dgram/bind-params.js benchmark #14948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 2 commits into from
Closed

benchmark: fix dgram/bind-params.js benchmark #14948

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c3cc7c
benchmark: fix dgram/bind-params.js benchmark
Trott Aug 19, 2017
3657264
[Squash] Address mscdex's suggestion
jasnell Aug 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[Squash] Address mscdex's suggestion 
@Trott, feel free to drop this out if you disagree.
  • Loading branch information
@jasnell
jasnell authored Aug 23, 2017
commit 36572642ab2c4d2d784cd5702a05daa94622440d
7 changes: 4 additions & 3 deletions benchmark/dgram/bind-params.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ const configs = {
};

const bench = common.createBenchmark(main, configs);
const noop = () => {};

function main(conf) {
const n = +conf.n;
Expand All @@ -20,7 +21,7 @@ function main(conf) {
bench.start();
for (let i = 0; i < n; i++) {
dgram.createSocket('udp4').bind(port, address)
.on('error', () => {})
.on('error', noop)
.unref();
}
bench.end(n);
Expand All @@ -29,7 +30,7 @@ function main(conf) {
for (let i = 0; i < n; i++) {
dgram.createSocket('udp4')
.bind(port)
.on('error', () => {})
.on('error', noop)
.unref();
}
bench.end(n);
Expand All @@ -38,7 +39,7 @@ function main(conf) {
for (let i = 0; i < n; i++) {
dgram.createSocket('udp4')
.bind()
.on('error', () => {})
.on('error', noop)
.unref();
}
bench.end(n);
Expand Down