Closed
Conversation
nodejs-github-bot
added
the
c++
bnoordhuis
approved these changes
Sep 8, 2017
src/module_wrap.cc
Outdated
Member
There was a problem hiding this comment.
Is this necessary if all fields have a default initializer?
src/module_wrap.cc
Outdated
Member
There was a problem hiding this comment.
Can you replace this with an UNREACHABLE()?
Member
There was a problem hiding this comment.
Hm, would it not even be better to just remove the else instead and have the regular return afterwards?
PR-URL: nodejs#15275 Author: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
jasnell
approved these changes
Sep 12, 2017
Member
Member
|
Linting failed oddly.. trying again: https://ci.nodejs.org/job/node-test-linter/11804/ |
jasnell
pushed a commit
that referenced
this pull request
Sep 15, 2017
PR-URL: #15275 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in 0fc402b |
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 17, 2017
PR-URL: nodejs/node#15275 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Sep 20, 2017
PR-URL: #15275 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Qard
pushed a commit
to Qard/ayo
that referenced
this pull request
Sep 21, 2017
PR-URL: nodejs/node#15275 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
module