Skip to content

test: replace string concatenation with template literals #15924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jphblais wants to merge 3 commits into from
Closed

test: replace string concatenation with template literals #15924

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32047f6
test: replace string concatenation with template literals
jphblais Oct 6, 2017
705a09f
test: improve coverage of lib/internal/loader/ModuleMap.js
jphblais Oct 7, 2017
528644a
Merge remote-tracking branch 'upstream/master'
jphblais Oct 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: replace string concatenation with template literals
  • Loading branch information
@jphblais
jphblais committed Oct 6, 2017
commit 32047f604cae5e7c08a082127014ef44d4e4f042
10 changes: 5 additions & 5 deletions test/parallel/test-whatwg-url-searchparams-sort.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,18 +40,18 @@ const { test, assert_equals, assert_array_equals } = require('../common/wpt');
assert_array_equals(param, val.output[i])
i++
}
}, "Parse and sort: " + val.input)
}, `Parse and sort: ${val.input}`)

test(() => {
let url = new URL("?" + val.input, "https://example/")
let url = new URL(`?${val.input}`, "https://example/")
url.searchParams.sort()
let params = new URLSearchParams(url.search),
i = 0
for(let param of params) {
assert_array_equals(param, val.output[i])
i++
}
}, "URL parse and sort: " + val.input)
}, `URL parse and sort: ${val.input}`)
})

test(function() {
Expand Down Expand Up @@ -90,7 +90,7 @@ tests.forEach((val) => {
assert_array_equals(param, val.output[i]);
i++;
}
}, 'Parse and sort: ' + val.input);
}, `Parse and sort: ${val.input}`);

test(() => {
const url = new URL(`?${val.input}`, 'https://example/');
Expand All @@ -101,5 +101,5 @@ tests.forEach((val) => {
assert_array_equals(param, val.output[i]);
i++;
}
}, 'URL parse and sort: ' + val.input);
}, `URL parse and sort: ${val.input}`);
});