Closed
Conversation
Contributor
Author
|
This was a second contribution suggestion from Node.js interactive conf |
mscdex
added
dgram
jasnell
approved these changes
Oct 12, 2017
Member
Trott
requested changes
Oct 12, 2017
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
More settings should be passed to reduce the number of benchmarks each file runs to one. So type=send, num=1, len=1, and probably others...
Contributor
Contributor
|
Closing this as there hasn't been any movement on it in a while but feel free to re-open if you would like to continue work on this, @jopann. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)