Closed
Conversation
Contributor
|
The commit message should have a subsystem prefix like |
Member
thefourtheye
force-pushed
the
patch-1
branch
2 times, most recently
from
f151947 to
850610c
Compare
If `len(args)` is lesser than two, then `install_path = dst_dir + node_prefix + '/'` would throw a `NameError`, because `dst_dir` will not be defined yet. So we are assigning `''` as the default value.
Contributor
Author
|
@mscdex @bnoordhuis Thanks Guys. I force pushed my commit. Please check now. |
Fishrock123
pushed a commit
that referenced
this pull request
May 7, 2015
If `len(args)` is less than two, then `install_path = dst_dir + node_prefix + '/'` would throw a `NameError`, because `dst_dir` will not be defined yet. So we are assigning `''` as the default value. PR-URL: #1628 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Contributor
|
Thanks, landed in b97b96d |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
May 19, 2015
If `len(args)` is less than two, then `install_path = dst_dir + node_prefix + '/'` would throw a `NameError`, because `dst_dir` will not be defined yet. So we are assigning `''` as the default value. PR-URL: nodejs#1628 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
len(args)is lesser than two, theninstall_path = dst_dir + node_prefix + '/'would throw aNameError, becausedst_dirwill not be defined yet. So, we are assigning an empty string as the default value, iflen(args)is lesser than or equal to two.