build: runtime-deprecate requiring deps

[TimothyGu]

Fixes: #15566 (comment)

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

Affected core subsystem(s)

build

[refack]

Isn't this major

[bnoordhuis]

FWIW, I'd be okay with simple removal. It seems vanishingly unlikely that anyone is using these.

[bnoordhuis]

Style nit: deprecated_deps

[TimothyGu]

Fixed.

[bnoordhuis]

This maps deps/foo/bar.js to internal/deps/foo/bar.js.

I don't think you have to special-case for node-inspect or v8 because anything from deps/ should pretty much be internal by default. ISTM it can be simplified to his:

if split[0] === 'deps':
  split[0] = 'internal'
else:
  split = split[1:]

Could be simplified further by just matching on name:

name = '/'.join(re.split('/|\\\\', name))
if name.startswith('lib/'):
  name = name[len('lib/'):]
elif name.startswith('deps/'):
  deprecated_deps, name = name, 'internal/' + name[len('deps/'):]

Bonus points: you won't have to '/'.join(...) below.

[bnoordhuis]

I think I misread the intent of this code - it's prefixing with internal/ unconditionally but stashing the original away. Could still be simplified, though:

name = '/'.join(re.split('/|\\\\', name))
if name.startswith('deps/node-inspect/') or name.startswith('deps/v8/'):
  deprecated_deps = name[len('deps/'):]
  name = 'internal/' + name
elif name.startswith('lib/'):
  name = name[len('lib/'):]

[TimothyGu]

@bnoordhuis Not only that, but internal/ should also be added to any other file in deps/ that do not match node-inspect and v8 to prevent them from being visible to userland, thus the code in its current form.

[jasnell]

LGTM once @bnoordhuis is happy also.

[cjihrig]

LGTM once nits are addressed.

[jasnell]

generally LGTM once @bnoordhuis is happy also

[TimothyGu]

@bnoordhuis PTAL.

New CI: https://ci.nodejs.org/job/node-test-pull-request/11345/

[TimothyGu]

Landed in 0e10717.