doc: add guide to maintaining npm by MylesBorins · Pull Request #16541 · nodejs/node

MylesBorins · 2017-10-27T03:32:41Z

This is based on the guide found on their wiki

refs: https://github.com/npm/npm/wiki/CLI-Team-Process#submitting-the-new-latest-x-to-nodejs

/cc @nodejs/npm

lpinca · 2017-10-27T07:42:30Z

doc/guides/maintaining-npm.md

Nit: can we use the triple ` instead of the indentation? I think it's more common in our guides.

```console $ git clone https://github.com/npm/npm.git ```

Would be nice

lpinca · 2017-10-27T07:52:32Z

doc/guides/maintaining-npm.md

Nit: I would add a comment explaining that the assumption is that the node repo is in the same directory of the npm repo.

Or just cd /path/to/node

Fishrock123 · 2017-10-27T22:08:27Z

doc/guides/maintaining-npm.md

MylesBorins · 2017-11-07T17:33:57Z

updated based on comments. Would still like to have a sign off from @iarna or @zkat before landing this

BridgeAR · 2017-11-23T21:28:09Z

Linter https://ci.nodejs.org/job/node-test-linter/13876/

BridgeAR · 2017-11-23T21:30:56Z

Ping @iarna @zkat

@MylesBorins do you want to wait further?

mhdawson

LGTM

zkat

Looks good! Couple of minor bits but otherwise 👍

zkat · 2017-11-26T02:50:23Z

doc/guides/maintaining-npm.md

We don't use master. This should be latest.

zkat · 2017-11-26T02:51:40Z

doc/guides/maintaining-npm.md

Shouldn't this be -A, to make sure files are both added and removed?

When I was doing it with -A it wasn't adding all the files. I believe add -f will add and remove.

As of git 2.0, git add adds removed files as well as added files.

git add -f is about adding gitignored files, not sure we'd want that. @MylesBorins which files weren't being added?

Yeah, if some files are missing, we should probably modify a rule in our .gitignore

I've updated and opened #17363

zkat · 2017-11-26T02:53:50Z

doc/guides/maintaining-npm.md

It might be worth warning folks that this might end up including changes to -other- licenses, and that wouldn't be appropriate for this commit. They should make sure to check that any changes are actually npm-check related.

zkat · 2017-11-26T02:56:56Z

doc/guides/maintaining-npm.md

I would add a note to run npm dist-tag ls npm and make sure this is the latest dist-tag. latest on git is usually released as next when it's time to downstream.

fixed below

zkat · 2017-11-26T03:00:47Z

doc/guides/maintaining-npm.md

sp: necessary

MylesBorins · 2017-11-26T03:48:44Z

Updated with requested changes. PTAL

gibfahn

LGTM apart from the git add -f thing, which I'm not sure about.

gibfahn · 2017-11-26T10:44:10Z

doc/guides/maintaining-npm.md

Maybe just

git remote update -p git checkout -b npm-x.y.z origin/master

@MylesBorins ^

MylesBorins · 2017-11-26T22:21:42Z

We explicitly want to add all files in the npm folder including those normally ignored This is similar to eslint / remark deps

…

On Nov 26, 2017 7:54 PM, "Michaël Zasso" ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In doc/guides/maintaining-npm.md <#16541 (comment)>: > + +```console +$ cd /path/to/node +$ git checkout master +$ git remote update -p +$ git reset --hard origin master +$ git checkout -b npm-x.y.z +$ cd deps +$ rm -rf npm +``` + +## Step 4: Extract and commit new npm + +```console +$ tar zxf /path/to/npm/release/npm-x.y.z.tgz +$ git add -f npm Yeah, if some files are missing, we should probably modify a rule in our .gitignore — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#16541 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAecV4GcrG-qDwxVOmonfmx0OCgZlP5Mks5s6UN9gaJpZM4QIgKS> .

MylesBorins · 2017-11-28T01:54:55Z

I've opened #17363 to help with the problem of files in the npm tree not being tracked by default

gibfahn · 2017-11-28T12:23:18Z

I think an npm update has gotten into the branch...

MylesBorins · 2017-11-28T12:38:56Z

lol. This is what I get for trying to test things and multi tasking. I'll update when I get back to computer

This is based on the guide found on their wiki refs: https://github.com/npm/npm/wiki/CLI-Team-Process#submitting-the-new-latest-x-to-nodejs

MylesBorins · 2017-11-29T02:47:52Z

@gibfahn ptal. This should be in working order now, I'll land in 24 hours if no one has any complaints. As this primarily mirrors the guide found on the npm wiki I don't think we need to block on the gitignore PR to land this

See https://github.com/nodejs/node/pull/16541/files#r153066081

gibfahn · 2017-11-29T11:38:00Z

@MylesBorins went ahead and pushed my suggestion, remove it if you disagree (I'm assuming it simply got lost). LGTM.

This has 11 (!) approvals, and you've addressed all of @zkat's suggestions, so this should be good to land.

mhdawson · 2017-11-29T14:48:53Z

Ci run: https://ci.nodejs.org/job/node-test-pull-request/11803/

zkat

👍

MylesBorins · 2017-11-30T00:41:21Z

landed in f2eaf87
@zkat any interest in updating the npm wiki?

This is based on the guide found on their wiki refs: https://github.com/npm/npm/wiki/CLI-Team-Process#submitting-the-new-latest-x-to-nodejs PR-URL: #16541 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 27, 2017

jasnell approved these changes Oct 27, 2017

View reviewed changes

lpinca approved these changes Oct 27, 2017

View reviewed changes

gireeshpunathil approved these changes Oct 27, 2017

View reviewed changes

cjihrig approved these changes Oct 27, 2017

View reviewed changes

apapirovski approved these changes Oct 27, 2017

View reviewed changes

Fishrock123 reviewed Oct 27, 2017

View reviewed changes

doc/guides/maintaining-npm.md Outdated

Copy link

Contributor

Fishrock123 Oct 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove?

Fishrock123 approved these changes Oct 27, 2017

View reviewed changes

targos approved these changes Oct 29, 2017

View reviewed changes

maclover7 mentioned this pull request Oct 31, 2017

Guide on introducing new dependencies in the codebase #16640

Closed

hiroppy approved these changes Nov 2, 2017

View reviewed changes

maclover7 mentioned this pull request Nov 4, 2017

tools: update to ESLint 4.10.0 #16738

Merged

2 tasks

MylesBorins force-pushed the npm-guide branch from 18f45e7 to 0714847 Compare November 7, 2017 17:33

BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 23, 2017

BridgeAR approved these changes Nov 23, 2017

View reviewed changes

mhdawson approved these changes Nov 24, 2017

View reviewed changes

zkat suggested changes Nov 26, 2017

View reviewed changes

MylesBorins force-pushed the npm-guide branch from 0714847 to cdb787a Compare November 26, 2017 03:48

gibfahn approved these changes Nov 26, 2017

View reviewed changes

doc: add guide to maintaining npm

94952ac

This is based on the guide found on their wiki refs: https://github.com/npm/npm/wiki/CLI-Team-Process#submitting-the-new-latest-x-to-nodejs

MylesBorins force-pushed the npm-guide branch from a5779e1 to 94952ac Compare November 29, 2017 01:46

suggestion: simplify checkout

59cd7ab

See https://github.com/nodejs/node/pull/16541/files#r153066081

zkat approved these changes Nov 29, 2017

View reviewed changes

MylesBorins closed this Nov 30, 2017

addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 30, 2017

MylesBorins mentioned this pull request Dec 12, 2017

v9.3.0 proposal #17631

Merged

gibfahn added land-on-v6.x labels Dec 19, 2017

gibfahn mentioned this pull request Dec 20, 2017

v8.9.4 proposal #17772

Closed

gibfahn mentioned this pull request Dec 20, 2017

v8.9.4 proposal #17774

Merged

MylesBorins mentioned this pull request Dec 20, 2017

v6.12.3 proposal #17776

Merged

Uh oh!

Conversation

MylesBorins commented Oct 27, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MylesBorins commented Nov 7, 2017

Uh oh!

BridgeAR commented Nov 23, 2017

Uh oh!

BridgeAR commented Nov 23, 2017

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

zkat left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gibfahn Nov 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MylesBorins commented Nov 26, 2017

Uh oh!

gibfahn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MylesBorins commented Nov 26, 2017 via email

Uh oh!

MylesBorins commented Nov 28, 2017

Uh oh!

gibfahn commented Nov 28, 2017

Uh oh!

MylesBorins commented Nov 28, 2017

Uh oh!

MylesBorins commented Nov 29, 2017

Uh oh!

gibfahn commented Nov 29, 2017

Uh oh!

mhdawson commented Nov 29, 2017

Uh oh!

zkat left a comment

Choose a reason for hiding this comment

Uh oh!

MylesBorins commented Nov 30, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

gibfahn Nov 26, 2017 •

edited

Loading