Skip to content

Backport: Set dynamic import callback #17823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hybrist wants to merge 5 commits into from
Closed

Backport: Set dynamic import callback #17823

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cef8dc9
deps: cherry-pick dbfe4a49d8 from upstream V8
Nov 9, 2017
8102dbb
module: Set dynamic import callback
Oct 1, 2017
b369026
fixup! deps: cherry-pick dbfe4a49d8 from upstream V8
Dec 22, 2017
e9af79c
module: enable dynamic import flag for esmodules
MylesBorins Jan 25, 2018
21d92c3
fixup! deps: cherry-pick dbfe4a49d8 from upstream V8
Feb 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! deps: cherry-pick dbfe4a49d8 from upstream V8
  • Loading branch information
Jan Krems committed Feb 1, 2018
commit 21d92c3e22c0e1af96ecfe01f581ea1c42736d98
1 change: 1 addition & 0 deletions deps/v8/test/cctest/test-api.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19108,6 +19108,7 @@ TEST(Regress528) {

THREADED_TEST(ScriptOrigin) {
LocalContext env;
v8::HandleScope scope(env->GetIsolate());
// Backed out for ABI compatibility with V8 6.2
// v8::Isolate* isolate = env->GetIsolate();
// v8::HandleScope scope(isolate);
Expand Down