doc: prefer make test-only when verifying the build#18061
Closed
joyeecheung wants to merge 1 commit intonodejs:masterfrom
Closed
doc: prefer make test-only when verifying the build#18061joyeecheung wants to merge 1 commit intonodejs:masterfrom
joyeecheung wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
build
joyeecheung
commented
Jan 9, 2018
BUILDING.md
Outdated
Member
Author
There was a problem hiding this comment.
I am wondering if there is anyone out there using the existing make check (alias to make test) because to me make check sounds better than make test-only for that purpose.
jasnell
approved these changes
Jan 9, 2018
Fishrock123
approved these changes
Jan 9, 2018
Member
Author
joyeecheung
added
the
author ready
XadillaX
approved these changes
Jan 10, 2018
lpinca
approved these changes
Jan 10, 2018
Trott
reviewed
Jan 10, 2018
BUILDING.md
Outdated
Trott
reviewed
Jan 10, 2018
BUILDING.md
Outdated
Member
There was a problem hiding this comment.
Nit: Instead of Which also runs linters... maybe `make test` will run linters...
Member
Author
There was a problem hiding this comment.
I have changed this to
`make test` does a full check on the codebase, including running linters and
documentation tests.
so it's clearer about what it does.
danbev
approved these changes
Jan 11, 2018
joyeecheung
force-pushed
the
test-only-doc
branch
from
f8bc125 to
ef4d62d
Compare
Member
Author
|
Landed in e8c491a, thanks! |
joyeecheung
added a commit
that referenced
this pull request
Jan 12, 2018
PR-URL: #18061 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
TimothyGu
removed
the
author ready
evanlucas
pushed a commit
that referenced
this pull request
Jan 30, 2018
PR-URL: #18061 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 27, 2018
PR-URL: #18061 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc