test: add common.crashOnUnhandledRejection to addons/callback-scope#18076
Closed
shqld wants to merge 1 commit intonodejs:masterfrom
shqld:add-common-crashonunhandledrejection
Closed
test: add common.crashOnUnhandledRejection to addons/callback-scope#18076shqld wants to merge 1 commit intonodejs:masterfrom shqld:add-common-crashonunhandledrejection
shqld wants to merge 1 commit intonodejs:masterfrom
shqld:add-common-crashonunhandledrejection
Conversation
nodejs-github-bot
added
addons
addaleax
approved these changes
Jan 10, 2018
hiroppy
added
the
code-and-learn
hiroppy
approved these changes
Jan 10, 2018
Member
cjihrig
approved these changes
Jan 10, 2018
lpinca
approved these changes
Jan 10, 2018
| const assert = require('assert'); | ||
| const { testResolveAsync } = require(`./build/${common.buildType}/binding`); | ||
|
|
||
| common.crashOnUnhandledRejection(); |
Member
There was a problem hiding this comment.
I'm fine with this but there is an assertion below in the setTimeout() callback which should make this redundant.
Author
There was a problem hiding this comment.
Should I make any changes to merge?
Member
There was a problem hiding this comment.
@lpinca common.crashOnUnhandledRejection(); would display the rejection in the trace instead of a timeout though.
joyeecheung
added
the
author ready
TimothyGu
approved these changes
Jan 13, 2018
Member
|
Landed in c84582c. 🎉! |
TimothyGu
removed
the
author ready
TimothyGu
pushed a commit
that referenced
this pull request
Jan 13, 2018
PR-URL: #18076 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 30, 2018
PR-URL: #18076 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 27, 2018
PR-URL: #18076 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This is my first commit to
nodejs/node, which is from nodejs/code-and-learn#77. Thanks in advance. 🙇I added
common.crashOnUnhandledRejectiontotest/addons/callback-scope/test-resolve-async.js.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test