[v8.x] lib: refactor ES module loader for readability

[addaleax]

PR-URL: #16579

Only merge conflict was in errors.md

[gibfahn]

Ran this locally and got:

make[1]: Leaving directory `/dev/shm/node/out'
if [ ! -r node -o ! -L node ]; then ln -fs out/Release/node node; fi
make -s build-addons
internal/loader/ModuleJob.js:1
(function (exports, require, module, __filename, __dirname) { 'use strict';
                                                              ^

ReferenceError: internalBinding is not defined
    at internal/loader/ModuleJob.js:1:63
    at NativeModule.compile (bootstrap_node.js:597:7)
    at NativeModule.require (bootstrap_node.js:542:18)
    at internal/loader/ModuleMap.js:3:19
    at NativeModule.compile (bootstrap_node.js:597:7)
    at NativeModule.require (bootstrap_node.js:542:18)
    at internal/loader/Loader.js:7:19
    at NativeModule.compile (bootstrap_node.js:597:7)
    at NativeModule.require (bootstrap_node.js:542:18)
    at module.js:45:16
/bin/sh: node: command not found
make[1]: *** [test/addons/.docbuildstamp] Error 127
make[1]: *** Waiting for unfinished jobs....
  touch 30580d6d8e368bd2d7a8507d249a0921e7c48fba.intermediate
  LD_LIBRARY_PATH=/dev/shm/node/out/Release/lib.host:/dev/shm/node/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../deps/v8/src/inspector; mkdir -p /dev/shm/node/out/Release/obj/gen/src/inspector/protocol /dev/shm/node/out/Release/obj/gen/include/inspector; python ../../third_party/inspector_protocol/CodeGenerator.py --jinja_dir ../../third_party --output_base "/dev/shm/node/out/Release/obj/gen/src/inspector" --config inspector_protocol_config.json
make: *** [test] Error 2

CI to check: https://ci.nodejs.org/job/node-test-commit/16347/
https://ci.nodejs.org/job/node-test-commit/16361/

[gibfahn]

Rerun to check it's still not working: https://ci.nodejs.org/job/node-test-pull-request/13776/

Also ping @addaleax 😁

[guybedford]

This should be const { ModuleWrap } = require('internal/process').internalBinding('module_wrap');

[MylesBorins]

ping @addaleax

[addaleax]

sorry for dropping the ball on this, i’ll get to it as soon as i have time (which is the case for basically all my open prs – not that i don’t appreciate pings). if this is urgent for anybody, feel free to just push to this branch and kick off ci. i, however, am going to sleep now. night everyone!

[MylesBorins]

@addaleax just pinging as a reflex, lmk if you would prefer I hold off on pinging you for a minute

[guybedford]

I've pushed up the internalBinding fix here, and run a new CI job - https://ci.nodejs.org/job/node-test-pull-request/14040/.

Updated CI: https://ci.nodejs.org/job/node-test-pull-request/14136/

[guybedford]

Note - CI here is now passing, although there seem to be some unrelated CI failures.

[gibfahn]

CI rerun: https://ci.nodejs.org/job/node-test-commit/17659/

CI again: https://ci.nodejs.org/job/node-test-commit/17670/

[gibfahn]

Just to check, this would be semver-major as it adds a new Error message, but ESM is still experimental. Is that correct?

[gibfahn]

Landed in 2019b02

Thanks for fixing this up @guybedford !