Revert "doc: import() is supported now"#18141
Closed
MylesBorins wants to merge 1 commit intonodejs:v9.x-stagingfrom
Closed
Revert "doc: import() is supported now"#18141MylesBorins wants to merge 1 commit intonodejs:v9.x-stagingfrom
MylesBorins wants to merge 1 commit intonodejs:v9.x-stagingfrom
Conversation
This reverts commit 977fb13. This should not have landed on v9.x which does not yet support the feature
MylesBorins
force-pushed
the
revert-dynamic-import-doc-v9.x
branch
from
81b07b9 to
dc4c2ac
Compare
Trott
approved these changes
Jan 14, 2018
lpinca
approved these changes
Jan 14, 2018
danbev
approved these changes
Jan 14, 2018
TimothyGu
approved these changes
Jan 14, 2018
fhinkel
approved these changes
Jan 14, 2018
XadillaX
approved these changes
Jan 15, 2018
evanlucas
approved these changes
Jan 15, 2018
jasnell
approved these changes
Jan 15, 2018
joyeecheung
added
the
author ready
evanlucas
pushed a commit
that referenced
this pull request
Jan 17, 2018
This reverts commit 977fb13. This should not have landed on v9.x which does not yet support the feature PR-URL: #18141 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Contributor
|
Landed in 722fe46. Thanks! |
addaleax
removed
the
author ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 977fb13.
This should not have landed on v9.x which not yet support the feature