[v8.x-backport] http2,perf_hooks: perf state using AliasedBuffer#18364
Closed
kfarnung wants to merge 1 commit intonodejs:v8.x-stagingfrom
Closed
[v8.x-backport] http2,perf_hooks: perf state using AliasedBuffer#18364kfarnung wants to merge 1 commit intonodejs:v8.x-stagingfrom
kfarnung wants to merge 1 commit intonodejs:v8.x-stagingfrom
Conversation
nodejs-github-bot
added
c++
kfarnung
added
the
perf_hooks
2 tasks
Member
|
@kfarnung I don’t know if you are aware, but the rule is that commits need to live for at least 2 weeks in a Current (9.x) release before they are merged into an LTS branch … it’s cool that you already opened this PR, and I’ll gladly review it, but be prepared to rebase this a couple times. |
Contributor
Author
|
Thanks @addaleax, I wasn't sure of the process here. I just wanted to get the PR open while it was still fresh. I'll keep an eye on it and periodically rebase. I mostly wasn't sure if @jasnell was eventually planning to backport the http2 change and figured this was the best way to start that discussion. |
kfarnung
changed the title
Merged
2 tasks
kfarnung
force-pushed
the
v8.x-backport-18300
branch
from
36703af to
0a7cfe5
Compare
Update performance_state to use AliasedBuffer and update usage sites. PR-URL: nodejs#18300 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
kfarnung
force-pushed
the
v8.x-backport-18300
branch
from
0a7cfe5 to
29ba51d
Compare
Member
|
Landed in dea44b9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backported PR #18300 to v8.x-staging. The backport dropped the http2 portion of the change since the dependent change hasn't been backported (yet?).
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
perf_hooks