Skip to content

Refactor test http exceptions #18506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Bamieh wants to merge 8 commits into from
Closed

Refactor test http exceptions #18506

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f802a56
Fixes: https://github.com/nodejs/node/issues/17169 (test-http-excepti…
Bamieh Nov 21, 2017
4cd8fbc
mustCall inside countdown
Bamieh Nov 23, 2017
4286f71
Add test case for countdown
Bamieh Nov 23, 2017
1eb069c
Update countdown docs to hint the change
Bamieh Nov 23, 2017
7ad8ce7
Update README.md
Bamieh Nov 23, 2017
6f125e1
Update README.md
Bamieh Nov 23, 2017
0060979
update readme
Bamieh Feb 1, 2018
6840cf3
up up up one line
Bamieh Feb 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
up up up one line 
remove typo
  • Loading branch information
@Bamieh
Bamieh committed Feb 9, 2018
commit 6840cf3796475df025f0e0103a255119aff6a017
3 changes: 1 addition & 2 deletions test/parallel/test-http-exceptions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,7 @@ function onUncaughtException(err) {
}

process.on('uncaughtException',
common.mustCall(onUncaughtException, NUMBER_OF_EXCEPTIONS)
);
common.mustCall(onUncaughtException, NUMBER_OF_EXCEPTIONS));
Copy link
Member

@BridgeAR BridgeAR Feb 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, the common.mustCall is obsolete here, because the test will not execute countdown.dec() in case it would not be called and would then fail because the wrapper around the countdown would fail.


server.listen(0, function() {
for (let i = 0; i < NUMBER_OF_EXCEPTIONS; i += 1) {
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http2-no-more-streams.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ server.listen(0, common.mustCall(() => {
const countdown = new Countdown(2, () => {
server.close();
client.close();
}));
});

{
// This one will be ok
Expand Down