Skip to content

doc: add process.debugPort to doc/api/process.md #18716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
flickz wants to merge 4 commits into from
Closed

doc: add process.debugPort to doc/api/process.md #18716

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4a4a877
doc: add process.debugPort to doc/api/process.md
flickz Feb 11, 2018
7f7564a
Rephrase process.debugPort api doc description
flickz Feb 11, 2018
ac43ad0
Update process.debugPort description
flickz Feb 12, 2018
393d898
Resolve Lint error
flickz Feb 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rephrase process.debugPort api doc description
  • Loading branch information
@flickz
flickz authored Feb 11, 2018
commit 7f7564a9bfd566c4ac619024d8e2fff8c5afffa1
2 changes: 1 addition & 1 deletion doc/api/process.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,7 +636,7 @@ added: v0.7.2
-->
* {number}

A port number for the debugger to listen to.
The port used by Node's debugger when enabled.
Copy link
Member

@BridgeAR BridgeAR Feb 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is actually called Node.js so it should be called Node.js's.

Copy link
Contributor Author

@flickz flickz Feb 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted


```js
process.debugPort = 5858;
Copy link
Member

@BridgeAR BridgeAR Feb 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter complains about the indentation. Please do not use any spaces here :-)

Expand Down