doc: update crypo Certficate class.#18721
Closed
antoine-amara wants to merge 1 commit intonodejs:masterfrom
Closed
doc: update crypo Certficate class.#18721antoine-amara wants to merge 1 commit intonodejs:masterfrom
antoine-amara wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
crypto
doc/api/crypto.md
Outdated
Contributor
There was a problem hiding this comment.
Nits:
"Note" -> "Note that" (with rewrapping within 80 characters).
"should'nt" -> "shouldn't".
Member
There was a problem hiding this comment.
I would prefer "should not" to make it a bit more formal.
doc/api/crypto.md
Outdated
Contributor
There was a problem hiding this comment.
Nit: it seems this should go before [HTML5's `keygen` element] ASCII-wise.
Contributor
|
cc @nodejs/crypto |
tniessen
approved these changes
Feb 12, 2018
antoine-amara
force-pushed
the
add-info-and-new-link-crypto-doc-#18662
branch
from
a069df8 to
c701271
Compare
Contributor
vsemozhetbyt
approved these changes
Feb 12, 2018
BridgeAR
added
the
author ready
Trott
reviewed
Feb 14, 2018
doc/api/crypto.md
Outdated
Member
There was a problem hiding this comment.
Nits: was -> is and project -> projects
update the dead link to <keygen> documentation. add a link to mozilla developper documentation because W3C delete the reference to this element. add a note to inform <keygen> element is deprecated since HTML 5.2. Fixes: nodejs#18662
antoine-amara
force-pushed
the
add-info-and-new-link-crypto-doc-#18662
branch
from
c701271 to
59379d3
Compare
Contributor
vsemozhetbyt
pushed a commit
that referenced
this pull request
Feb 14, 2018
Update the dead link to <keygen> documentation. Add a link to mozilla developper documentation because W3C deleted the reference to this element. Add a note to inform <keygen> element is deprecated since HTML 5.2. PR-URL: #18721 Fixes: #18662 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Contributor
|
Landed in 138bdf6 Thank you! |
priyank-p
added a commit
to nodejs/node-core-utils
that referenced
this pull request
Feb 17, 2018
This displays a warning if we cannot fetch user's name and email from github api, instead of displaying blank and null output in the author field (cli table). Refs: nodejs/node#18721 Fixes: #180
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
Update the dead link to <keygen> documentation. Add a link to mozilla developper documentation because W3C deleted the reference to this element. Add a note to inform <keygen> element is deprecated since HTML 5.2. PR-URL: #18721 Fixes: #18662 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
Update the dead link to <keygen> documentation. Add a link to mozilla developper documentation because W3C deleted the reference to this element. Add a note to inform <keygen> element is deprecated since HTML 5.2. PR-URL: #18721 Fixes: #18662 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Update the dead link to <keygen> documentation. Add a link to mozilla developper documentation because W3C deleted the reference to this element. Add a note to inform <keygen> element is deprecated since HTML 5.2. PR-URL: nodejs#18721 Fixes: nodejs#18662 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 7, 2018
Update the dead link to <keygen> documentation. Add a link to mozilla developper documentation because W3C deleted the reference to this element. Add a note to inform <keygen> element is deprecated since HTML 5.2. PR-URL: #18721 Fixes: #18662 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 7, 2018
Update the dead link to <keygen> documentation. Add a link to mozilla developper documentation because W3C deleted the reference to this element. Add a note to inform <keygen> element is deprecated since HTML 5.2. PR-URL: #18721 Fixes: #18662 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 9, 2018
Update the dead link to <keygen> documentation. Add a link to mozilla developper documentation because W3C deleted the reference to this element. Add a note to inform <keygen> element is deprecated since HTML 5.2. PR-URL: #18721 Fixes: #18662 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Aug 16, 2018
Update the dead link to <keygen> documentation. Add a link to mozilla developper documentation because W3C deleted the reference to this element. Add a note to inform <keygen> element is deprecated since HTML 5.2. PR-URL: #18721 Fixes: #18662 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
johnfrench3
pushed a commit
to johnfrench3/core-utils-node
that referenced
this pull request
Nov 2, 2022
This displays a warning if we cannot fetch user's name and email from github api, instead of displaying blank and null output in the author field (cli table). Refs: nodejs/node#18721 Fixes: nodejs/node-core-utils#180
renawolford6
added a commit
to renawolford6/node-dev-build-core-utils
that referenced
this pull request
Nov 10, 2022
This displays a warning if we cannot fetch user's name and email from github api, instead of displaying blank and null output in the author field (cli table). Refs: nodejs/node#18721 Fixes: nodejs/node-core-utils#180
Developerarif2
pushed a commit
to Developerarif2/node-core-utils
that referenced
this pull request
Jan 27, 2023
This displays a warning if we cannot fetch user's name and email from github api, instead of displaying blank and null output in the author field (cli table). Refs: nodejs/node#18721 Fixes: nodejs/node-core-utils#180
gerkai
added a commit
to gerkai/node-core-utils-project-build
that referenced
this pull request
Jan 27, 2023
This displays a warning if we cannot fetch user's name and email from github api, instead of displaying blank and null output in the author field (cli table). Refs: nodejs/node#18721 Fixes: nodejs/node-core-utils#180
patrickm68
added a commit
to patrickm68/NodeJS-core-utils
that referenced
this pull request
Sep 14, 2023
This displays a warning if we cannot fetch user's name and email from github api, instead of displaying blank and null output in the author field (cli table). Refs: nodejs/node#18721 Fixes: nodejs/node-core-utils#180
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update the dead link to documentation.
add a link to mozilla developper documentation because
W3C delete the reference to this element.
add a note to inform element is deprecated since HTML 5.2.
Fixes: #18662
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)