Skip to content

perf_hooks: fix timing #18993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TimothyGu wants to merge 4 commits into from
Closed

perf_hooks: fix timing #18993

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
484a3d8
perf_hooks: fix timing
TimothyGu Feb 25, 2018
d8a0744
fixup! fix units in variable name
TimothyGu Feb 27, 2018
497b54d
fixup! Reduce expected precision
TimothyGu Mar 4, 2018
ccc0ed2
fixup! fix FILETIME interpretation
TimothyGu Mar 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! Reduce expected precision
  • Loading branch information
@TimothyGu
TimothyGu committed Mar 4, 2018
commit 497b54d5a94d768afc44f6611f0a8fc3ba9d4da8
8 changes: 5 additions & 3 deletions test/parallel/test-performance.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,12 @@ const { performance } = require('perf_hooks');
assert(performance);
assert(performance.nodeTiming);
assert.strictEqual(typeof performance.timeOrigin, 'number');
assert(Math.abs(performance.timeOrigin - Date.now()) < 300);
// Use a fairly large epsilon value, since we can only guarantee that the node
// process started up in 20 seconds.
assert(Math.abs(performance.timeOrigin - Date.now()) < 20000);

const inited = performance.now();
assert(inited < 300);
assert(inited < 20000);

{
const entries = performance.getEntries();
Expand Down Expand Up @@ -113,7 +115,7 @@ function checkNodeTiming(props) {
if (props[prop].around !== undefined) {
assert.strictEqual(typeof performance.nodeTiming[prop], 'number');
const delta = performance.nodeTiming[prop] - props[prop].around;
assert(Math.abs(delta) < 500);
assert(Math.abs(delta) < 1000);
} else {
assert.strictEqual(performance.nodeTiming[prop], props[prop]);
}
Expand Down