[v9.x backport] doc: fix a typo in util.isDeepStrictEqual & doc: add missing Returns in fs & util#19127
Closed
shqld wants to merge 2 commits intonodejs:v9.x-stagingfrom
shqld:backport-18775-to-v9.x
Closed
[v9.x backport] doc: fix a typo in util.isDeepStrictEqual & doc: add missing Returns in fs & util#19127shqld wants to merge 2 commits intonodejs:v9.x-stagingfrom shqld:backport-18775-to-v9.x
Returns in fs & util#19127shqld wants to merge 2 commits intonodejs:v9.x-stagingfrom
shqld:backport-18775-to-v9.x
Conversation
Author
|
I made this though I wonder if backport PRs should be created by a collaborator. 🤔 |
Member
|
@shqld no, it's fine. |
lpinca
approved these changes
Mar 4, 2018
benjamingr
approved these changes
Mar 4, 2018
Member
I just want to echo that we're really grateful for anyone who is willing to raise backport PRs for us, definitely not necessary for you to be a collaborator! |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 6, 2018
Backport-PR-URL: #19127 PR-URL: #18775 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 6, 2018
Backport-PR-URL: #19127 PR-URL: #18775 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Contributor
|
landed in 479b622...e42600f |
Author
|
Thanks lpinca & gibfahn! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport PR related to #18775 .
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc