assert: do not use EOL in ERR_ASSERTION messages

[joyeecheung]

On Windows if an error is thrown from a script that uses \n
to break lines - which is very common in the JavaScript ecosystem,
and is the case in our own code base -
then the error messages would contain mixed line feeds:
the part coming from the source code breaks with \n while the
message itself break with \r\n.

Since we do not use \r\n in util.inspect(), we should use \n
in error messages as well.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

cc @BridgeAR

[joyeecheung]

I am wondering why this does not fail on the CI but fails on my Windows 10 machine. I have core.autocrlf = false because if I let git convert LF to CRLF the linter would go crazy about it.

EDIT: huh, I guess it's because the windows CI does not run the linter so it just converts LF in the code to CRLF and gets away with it..

[joyeecheung]

CI: https://ci.nodejs.org/job/node-test-pull-request/13582/

[vsemozhetbyt]

Refs: #18967

[vsemozhetbyt]

Is this semver-major?

[BridgeAR]

@vsemozhetbyt this is not semver-major because it relies on a semver-major feature. I added the do not land labels.

[BridgeAR]

@joyeecheung this currently fails on the CI. When I implemented this I had the exact same issue when first using \n because something converted that to \r\n on Windows. I personally would like to only use \n but I am not sure how Windows handles this.

[joyeecheung]

@nodejs/build Can we set git config core.autocrlf false on the Windows CI? Letting git convert LF to CRLF causes the linter to fail on a Windows machine.

[MSLaguana]

Instead of setting a git config option, wouldn't it be better to add a line to .gitattributes explicitly specifying what line ending the relevant files are required to have?

[joyeecheung]

@MSLaguana That sounds like a better idea, I'll try to figure out the necessary update to .gitattributes, thanks for the advice!

[joaocgreis]

We should try to respect naive EOL where possible. I believe a better solution would be to mark this test explicitly for EOL normalization, adding something like this to .gitattributes:

test/parallel/test-assert.js text

[BridgeAR]

Superseded by #20754. Closing.