Skip to content

Fs stats added in versions#19266

Closed
jvelezpo wants to merge 2 commits intonodejs:masterfrom
jvelezpo:fs-stats-added-in-versions
Closed

Fs stats added in versions#19266
jvelezpo wants to merge 2 commits intonodejs:masterfrom
jvelezpo:fs-stats-added-in-versions

Conversation

@jvelezpo
Copy link
Contributor

@jvelezpo jvelezpo commented Mar 9, 2018

Almost all fs.Stats entries now have the added in version documented

Fixes:: #19178

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Affected core subsystem(s)
doc

jvelezpo added 2 commits March 9, 2018 09:57
@jvelezpo
doc: add added in versions to fs.Stats properties
7ee9a2e 
Adds the added in label on the documentation for each one of the
properties of Class: fs.Stats

Fixes:: #19178
@jvelezpo
doc: add added in versions to fs.Stats properties
3904c5d 
Adds more added in label on the documentation for each one of the
properties of Class: fs.Stats

Fixes:: #19178
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Mar 9, 2018
@jvelezpo
Copy link
Contributor Author

jvelezpo commented Mar 9, 2018 •
edited
Loading

Also as a note, the following fs.Stats entries are still missing their added in version

stats.dev
stats.ino
stats.mode
stats.nlink
stats.uid
stats.gid
stats.rdev
stats.blksize
stats.blocks

this entries have such a generic name that with my skills with grep i could not find the versions for them.
So if someone is willing to add the versions to these entries it would be great 👍

edsadr
edsadr approved these changes Mar 14, 2018
View reviewed changes
Copy link
Member

@edsadr edsadr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiroppy
Copy link
Member

hiroppy commented Mar 15, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request-lite/261/

@trivikr
Copy link
Member

trivikr commented Mar 25, 2018

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/323/

trivikr pushed a commit that referenced this pull request Mar 25, 2018
@jvelezpo @trivikr
doc: add added in versions to fs.Stats properties
1d8909b 
Adds the added in label on the documentation for each one of the
properties of Class: fs.Stats

PR-URL: #19266
Fixes: #19178
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@trivikr
Copy link
Member

trivikr commented Mar 25, 2018

Landed in 1d8909b

@trivikr trivikr closed this Mar 25, 2018
targos pushed a commit that referenced this pull request Mar 27, 2018
@jvelezpo @targos
doc: add added in versions to fs.Stats properties
157fc28 
Adds the added in label on the documentation for each one of the
properties of Class: fs.Stats

PR-URL: #19266
Fixes: #19178
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@jvelezpo jvelezpo deleted the fs-stats-added-in-versions branch September 6, 2018 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@edsadr edsadr edsadr approved these changes

@trivikr trivikr trivikr approved these changes

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jvelezpo @hiroppy @trivikr @jasnell @edsadr @nodejs-github-bot